Repository navigation
Sync plugin listing README from listed release - #553
Merged
Merged
Conversation
Instead of syncing the README from the default branch, it should be synced from the commit hash of the release that it's listed with. For example: a README change may have merged into `main` before a new release was tagged. This means the README may include documentation for changes that have not yet been released.
simonhamp
added a commit
that referenced
this pull request
Oct 20, 2026
The release discovery test chained once() before with(), so Mockery counted every warning call instead of just the sync warning. The service logs two warnings on that path (one in fetchLatestTag, one in sync), so it failed. Main has been red since #553 because of this. CI now runs phpunit with --no-progress instead of --testdox, so the log only shows failures, warnings and the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
added a commit
that referenced
this pull request
Oct 23, 2026
On a 403 the service logs two warnings: one from the tag lookup's catch and one from sync(). The test called once() before with(), and Mockery checks the count as soon as once() runs, so it counted both warnings and failed. Putting with() first makes once() apply to the "Could not discover latest release" warning only. Main has failed this test since #553. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
added a commit
that referenced
this pull request
Oct 23, 2026
* Document dashed, dotted and per-side borders in EDGE mobile-air#548 adds border-dashed, border-dotted and border-solid, and per-side widths (border-t/r/b/l/x/y). This lists them with the other supported classes, adds a section on how they compose and how dashes are spaced, and puts per-side colours and logical sides in the unsupported table. The badges say 4.7, so 4.7 joins the released versions list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix plugin sync log assertion and quiet CI test output The release discovery test chained once() before with(), so Mockery counted every warning call instead of just the sync warning. The service logs two warnings on that path (one in fetchLatestTag, one in sync), so it failed. Main has been red since #553 because of this. CI now runs phpunit with --no-progress instead of --testdox, so the log only shows failures, warnings and the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of syncing the README from the default branch, it should be synced from the commit hash of the release that it's listed with.
For example: a README change may have merged into
mainbefore a new release was tagged. This means the README may include documentation for changes that have not yet been released.